Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support event relations on all post message functions #806

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Support event relations on all post message functions #806

wants to merge 4 commits into from

Conversation

nvrWhere
Copy link
Collaborator

@nvrWhere nvrWhere commented Oct 4, 2024

Title

KitsuneRal
KitsuneRal reviewed Oct 5, 2024
View reviewed changes
Quotient/room.h Outdated Show resolved Hide resolved
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Nov 18, 2024
@nvrWhere
Support event relations on all post message functions
eecba51
@nvrWhere
Make all the functions non-callable from QML and remove postMessage b…
1b217c5 
…ecause we probably shouldn't allow someone to send a message with an arbritary type but not the correct content. This is replaced by postEmote and postNotice the two types that are probably valid from the original postMessage function.
@nvrWhere nvrWhere force-pushed the nvrwhere/relatesTo_post branch from a8025f1 to 1b217c5 Compare November 19, 2024 21:29
@nvrWhere
Copy link
Collaborator Author

So I updated the functions to make them not invokable as discussed. Also since we're breaking API i messed with them a little.

I removed postMessage because we probably shouldn't allow someone to send a message with an arbitrary type but not the correct content. This is replaced by postEmote and postNotice which along with postHtmlText are the types that are probably valid from the original postMessage function.

@nvrWhere nvrWhere requested a review from KitsuneRal November 20, 2024 09:49
KitsuneRal
KitsuneRal reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template suggestion is just a suggestion, open for discussion.

Quotient/room.h Outdated Show resolved Hide resolved
Quotient/room.h Outdated Show resolved Hide resolved
Quotient/room.h Outdated Show resolved Hide resolved
Quotient/room.cpp Outdated Show resolved Hide resolved
@nvrWhere nvrWhere requested a review from KitsuneRal December 1, 2024 12:58
KitsuneRal
KitsuneRal requested changes Dec 2, 2024
View reviewed changes
Quotient/room.cpp Outdated Show resolved Hide resolved
Quotient/room.cpp Outdated Show resolved Hide resolved
Quotient/room.cpp Outdated Show resolved Hide resolved
@nvrWhere nvrWhere force-pushed the nvrwhere/relatesTo_post branch from 80d145c to 9c2ec97 Compare December 2, 2024 17:11
@nvrWhere nvrWhere requested a review from KitsuneRal December 2, 2024 17:12
@KitsuneRal
Copy link
Member

Ftr (my own, in particular): this PR targets 0.10, not 0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasFella TobiasFella TobiasFella left review comments

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: 0.10(?) - To Do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvrWhere @KitsuneRal @TobiasFella