Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Generate C/C++ CamelCase forwarding headers #462

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

CarlSchwan
Copy link
Contributor

Fix #445 still WIP, I need to finish doingit for the csapi generated files too

@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label May 15, 2021
@KitsuneRal
Copy link
Member

One thing I'm not quite happy in this approach (and I understand that it's the way KDE goes, but still) is that one has to explicitly add the HeaderName every time a new public headername.h is added. I wonder how inaccurate would be a script picking a class name from the header file using some regex...

@TobiasFella
Copy link
Member

I wonder how inaccurate would be a script picking a class name from the header file

That script would at least need to magically figure out which letters to capitalize :/

@KitsuneRal
Copy link
Member

The "magic" would boil down to looking inside the file for case-insensitive matches of the file name and then using whatever case is there... and perhaps it would be best just to move on from thestreamofwords like roommemberevent.h - so let's do it once, rename the files to the likes of RoomMemberEvent.h, making production of extensionless symlinks a trivial task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for the library
Projects
Status: 0.9 - To Do
Development

Successfully merging this pull request may close these issues.

Move headers to dedicated libquotient directory
3 participants