Improve error handling

quotient-im · Dec 2, 2024 · 921d5a8 · 921d5a8
1 parent 8e4ad29
commit 921d5a8
Show file tree

Hide file tree

Showing 4 changed files with 992 additions and 603 deletions.
diff --git a/Quotient/connection.cpp b/Quotient/connection.cpp
@@ -393,6 +393,12 @@ void Connection::Private::setupCryptoMachine(const QByteArray& picklingKey)
     mxIdForDb.replace(u':', u'_');
     const QString databasePath{ QStandardPaths::writableLocation(QStandardPaths::AppDataLocation) % u'/' % mxIdForDb % u'/' % q->deviceId() };
     cryptoMachine = crypto::init(stringToRust(q->userId()), stringToRust(q->deviceId()), stringToRust(databasePath), bytesToRust(picklingKey));
+    if (!(*cryptoMachine)->is_ok()) {
+        //TODO as part of #782: if crypto machine creation fails, make PendingConnection fail to create a Connection. Then clients can show these errors nicely
+        // and we don't have to guard all functions for the crypto machine not being available.
+        qCritical() << "Failed to load crypto machine" << (int) (*cryptoMachine)->error() << stringFromRust((*cryptoMachine)->error_string());
+        qApp->exit(1);
+    }
 }
 
 void Connection::Private::completeSetup(const QString& mxId, bool newLogin,