Improved scrollindicators #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build Quaternion 0.0.175 completed (commit 30309190cd by @maralorn) |
|
Please feel free to comment on the design. I don’t think it’s perfect. |
This builds on top of the changs from @KitsuneRal The ActivityDetector is now only enabled, when really needed. This should fix quotient-im#104
This will show scrollindicators to the top and to the bottom with explanations, when there are unread messages in that direction
maralorn
force-pushed
the
improved-scrollindicators
branch
from
1073f7f to
78a2ca7
Compare
|
✅ Build Quaternion 0.0.180 completed (commit a57d02e154 by @maralorn) |
|
I assume this PR has bitrotten enough to just close it? It's great to see, that Quaternion is still going strong, but obviously my focus has shifted. |
|
Nope, still has enough useful code so I keep it around. Thanks for contributing back then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be merged after @KitsuneRal ’s readmarker handling and my activity-detector change.
For the rest see commit message