Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull request template #795

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Nov 21, 2024

Description

This removes some items from the pull request checklist that probably aren't necessary anymore:

  • GitHub will auto-assign a reviewer to all PRs now that we have code owners defined.
  • The testing infrastructure is robust enough that's not strictly necessary to test on one's own local computer before creating a PR (although still recommended).

Related issues

N/A

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 21, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 21, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 21, 2024
Copy link

sonarcloud bot commented Nov 21, 2024

@BenWibking BenWibking changed the title Update pull_request_template.md Update pull request template Nov 21, 2024
@BenWibking BenWibking added this pull request to the merge queue Nov 21, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
Merged via the queue into development with commit 83d3bf9 Nov 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants