Bump extern/amrex from 74127d6 to 6d9c25b
#761
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [extern/amrex](https://github.com/AMReX-Codes/amrex) from `74127d6` to `6d9c25b`. - [Release notes](https://github.com/AMReX-Codes/amrex/releases) - [Commits](AMReX-Codes/amrex@74127d6...6d9c25b) --- updated-dependencies: - dependency-name: extern/amrex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
requested review from
BenWibking and
markkrumholz
as code owners
dependabot
bot
added
dependencies
dosubot
bot
added
the
size:XS
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
We have an extremely weird test failure I've never seen before: |
|
Definitely something strange with the radtube test here -- there's a pure virtual function called exception in the log, and I have no idea what could be causing that. @chongchonghe, can you take a look and see if you can reproduce this problem? |
|
I found this blog post: https://www.artima.com/articles/pure-virtual-function-called-an-explanation It seems odd it happens at the very end, when the program would exit anyway. Hopefully something that should be obvious when run inside a debugger. |
|
I'll take a look. |
|
I was able to reproduce this error on gadi. It seems like the code that causes this error is |
|
Maybe we can sit down with the debugger together and have a look at this next week. I'll message you on slack to set a time. |
|
Both Release and Debug runs are successful on CPU. On gadi GPU, both Release and Debug runs give the same error message. The simulation finishes successfully (L1 norm is within tolerance), but as long as it executes |
Yes, we can sit down together and try to debug it. Just let me know what time works for you. |
### Description Move `DeviceVector` inside `setInitialConditionsOnGrid` to avoid the `pure virtual method called` error, first seen in #761 . This branch is based on dependabot/submodules/extern/amrex-6d9c25b . ### Related issues Fix issues in PR #761 ### Checklist _Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an `x` inside the square brackets `[ ]` in the Markdown source below:_ - [ ] I have added a description (see above). - [ ] I have added a link to any related issues see (see above). - [ ] I have read the [Contributing Guide](https://github.com/quokka-astro/quokka/blob/development/CONTRIBUTING.md). - [ ] I have added tests for any new physics that this PR adds to the code. - [ ] I have tested this PR on my local computer and all tests pass. - [ ] I have manually triggered the GPU tests with the magic comment `/azp run`. - [ ] I have requested a reviewer for this PR. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Close after #774 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps extern/amrex from
74127d6to6d9c25b.Commits
6d9c25bTinyProfiler: Remove unnecessary precision() call (#4174)ea4eb97Fix GCC 12 & 13 warnings on null-dereference (#4171)103d0e9fix: wavefront_size for gfx11* (#4170)cf67be5CI: Test GCC-13 (#4169)1541713ParmParse: Fix a GCC warning (#4168)467dd68allow hidden dimension when calling FFlux routines (#4162)35353fbDeregister BArena from Profiling in Arena::Finalize (#4164)1bfdb84Add assertion to new FillPatchTwoLevels introduced in #4158 (#4161)3734079FillPatchSingleLevel and FillPatchTwoLevels for ERF (#4158)6c7668cParmParse:addFile: User-Friendly Error (#4156)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)