Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print coordinates of cells where flux correction is needed #383

Merged
merged 14 commits into from
Sep 19, 2023

Conversation

psharda
Copy link
Contributor

@psharda psharda commented Sep 14, 2023

Closes #381

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
@psharda psharda changed the title Print coordinates of cells where flux correction fails Print coordinates of cells where flux correction is needed Sep 14, 2023
src/RadhydroSimulation.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/RadhydroSimulation.hpp Show resolved Hide resolved
src/RadhydroSimulation.hpp Show resolved Hide resolved
src/RadhydroSimulation.hpp Show resolved Hide resolved
src/RadhydroSimulation.hpp Show resolved Hide resolved
src/RadhydroSimulation.hpp Show resolved Hide resolved
src/RadhydroSimulation.hpp Show resolved Hide resolved
src/RadhydroSimulation.hpp Show resolved Hide resolved
src/RadhydroSimulation.hpp Show resolved Hide resolved
src/RadhydroSimulation.hpp Show resolved Hide resolved
@psharda
Copy link
Contributor Author

psharda commented Sep 15, 2023

/azp run

1 similar comment
@psharda
Copy link
Contributor Author

psharda commented Sep 15, 2023

/azp run

@psharda
Copy link
Contributor Author

psharda commented Sep 15, 2023

ugh, avatarGPUs throw nvcc error : 'cicc' died due to signal 9 (Kill signal)

@BenWibking
Copy link
Collaborator

Somehow the system ran out of memory when it was trying to compile. Maybe try again?

@BenWibking
Copy link
Collaborator

/azp run

@BenWibking
Copy link
Collaborator

/azp run

@BenWibking BenWibking added this pull request to the merge queue Sep 19, 2023
Merged via the queue into quokka-astro:development with commit ab9ca8b Sep 19, 2023
8 checks passed
@psharda psharda deleted the specie-limits branch February 5, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print coordinates of cells requiring flux correction
2 participants