-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LLF fallback solver #380
Conversation
/azp run |
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to how Riemann solvers are referenced is going to cause conflicts with the MHD branch, since the same changes will need to applied to the HLLD solver in that branch. I'm not sure where @AstroKriel's MHD branch is with respect to the repo, but we might want to have a look just to make sure that there won't be any pain points when we need to integrate these changes with the MHD HLLD solver.
The trivial solution is to just add another conditional case to the |
OK. I guess that should be done in a separate PR, which will have to happen before @AstroKriel's code can be merged into the main branch. |
Uses the Local-Lax Friedrichs (Rusanov) solver as a "fallback" Riemann solver.
Closes #379.