Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LLF fallback solver #380

Merged
merged 2 commits into from
Sep 14, 2023
Merged

add LLF fallback solver #380

merged 2 commits into from
Sep 14, 2023

Conversation

BenWibking
Copy link
Collaborator

Uses the Local-Lax Friedrichs (Rusanov) solver as a "fallback" Riemann solver.

Closes #379.

@BenWibking
Copy link
Collaborator Author

/azp run

@BenWibking
Copy link
Collaborator Author

/azp run

Copy link
Collaborator

@markkrumholz markkrumholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to how Riemann solvers are referenced is going to cause conflicts with the MHD branch, since the same changes will need to applied to the HLLD solver in that branch. I'm not sure where @AstroKriel's MHD branch is with respect to the repo, but we might want to have a look just to make sure that there won't be any pain points when we need to integrate these changes with the MHD HLLD solver.

@BenWibking
Copy link
Collaborator Author

The change to how Riemann solvers are referenced is going to cause conflicts with the MHD branch, since the same changes will need to applied to the HLLD solver in that branch. I'm not sure where @AstroKriel's MHD branch is with respect to the repo, but we might want to have a look just to make sure that there won't be any pain points when we need to integrate these changes with the MHD HLLD solver.

The trivial solution is to just add another conditional case to the if constexpr statement in HydroSystem::ComputeFluxes. I don't think it should be more involved than that.

@markkrumholz
Copy link
Collaborator

The change to how Riemann solvers are referenced is going to cause conflicts with the MHD branch, since the same changes will need to applied to the HLLD solver in that branch. I'm not sure where @AstroKriel's MHD branch is with respect to the repo, but we might want to have a look just to make sure that there won't be any pain points when we need to integrate these changes with the MHD HLLD solver.

The trivial solution is to just add another conditional case to the if constexpr statement in HydroSystem::ComputeFluxes. I don't think it should be more involved than that.

OK. I guess that should be done in a separate PR, which will have to happen before @AstroKriel's code can be merged into the main branch.

@markkrumholz markkrumholz added this pull request to the merge queue Sep 14, 2023
Merged via the queue into development with commit 16d5737 Sep 14, 2023
8 checks passed
@BenWibking BenWibking deleted the BenWibking/llf-fallback branch September 24, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fallback to LLF solver
2 participants