Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_chemistry_enabled #369

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Remove is_chemistry_enabled #369

merged 2 commits into from
Sep 9, 2023

Conversation

psharda
Copy link
Contributor

@psharda psharda commented Sep 8, 2023

We don't need the Physics_Trait is_chemistry_enabled anymore.

@psharda psharda marked this pull request as ready for review September 8, 2023 20:12
@BenWibking
Copy link
Collaborator

Looks fine to me. Should probably mention in this PR what the correct way to enable chemistry is instead.

@psharda
Copy link
Contributor Author

psharda commented Sep 8, 2023

One can enable chemistry using enableChemistry in RadhydroSimulation.hpp, following the example of primordial chemistry. Also need to compile Chemistry.hpp with the problem in question.

@psharda
Copy link
Contributor Author

psharda commented Sep 8, 2023

/azp run

@psharda psharda added this pull request to the merge queue Sep 8, 2023
@psharda psharda removed this pull request from the merge queue due to a manual request Sep 8, 2023
@BenWibking BenWibking added this pull request to the merge queue Sep 9, 2023
Merged via the queue into quokka-astro:development with commit bce9c28 Sep 9, 2023
8 checks passed
@psharda psharda deleted the rem_chem_enab branch February 5, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWibking BenWibking BenWibking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psharda @BenWibking