revert to first-order space+time flux when RK2 flux fails #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
/azp run |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
/azp run |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
/azp run |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
/azp run |
markkrumholz
previously approved these changes
Jan 31, 2023
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
BenWibking
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
/azp run |
|
/azp run |
BenWibking
changed the title
|
@markkrumholz here's the first FOFC fix. The boundary box consistency will go in the next PR. |
|
@markkrumholz All tests now pass. Please review at your convenience. |
markkrumholz
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the first-order flux correction so that it reverts to forward Euler with a donor cell flux (i.e., Godunov's method) for cells that produce negative densities with the RK2+PPM/PLM update. This replaces the fluxes surrounding problem cells, so that the overall method remains conservative.
This causes a tiny difference in the output of the HydroHighMach test. The solution looks no better or worse than before by eye, but the error tolerance is just slightly too stringent for it to pass, so it's updated here.
Fixes #218.