Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More UI tests #557

Merged
merged 2 commits into from
Jan 8, 2025
Merged

More UI tests #557

merged 2 commits into from
Jan 8, 2025

Conversation

mirekdlugosz
Copy link
Collaborator

These two commits add some new UI tests that were hard to implement while we still needed to think about supporting old UI:

  • a test for creating OpenShift credential using username and password
  • a test to download report through kebab menu item (technically kebab becomes the default way of downloading reports, and new test covers downloading through modal)

This depends on ouia IDs added in quipucords/quipucords-ui#531

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (0cb990a) to head (dc22f5f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   77.15%   77.15%           
=======================================
  Files           7        7           
  Lines         709      709           
=======================================
  Hits          547      547           
  Misses        162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirekdlugosz mirekdlugosz merged commit 4442ca8 into main Jan 8, 2025
11 checks passed
@mirekdlugosz mirekdlugosz deleted the more-ui-tests branch January 8, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants