Move credentials to API V2 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 76.85% 77.15% +0.29%
==========================================
Files 7 7
Lines 700 709 +9
==========================================
+ Hits 538 547 +9
Misses 162 162 ☔ View full report in Codecov by Sentry. |
The client assumed that the entire API will be under versioned path. Not a terrible assumption to make, but doesn't account for phased updates - where certain endpoints are moved to a new version, while others stay under old version.
Port qpc credentials tests to API v2. New API also requires SSH key content, as opposed to path to key file - this change is big enough to warrant a separate commit.
Port qpc credentials tests to API v2 - paste content of SSH key file where path was used in the past.
In qpc_model representing credential, move from ssh_keyfile to ssh_key. This also changes the meaning of the field - it used to represent path, now it represents the content of the file. However, when creating model from config definition, it still takes the path and reads the content automatically. This way we don't have to modify existing configuration files. And storing entire keys in configuration files is going to be cumbersome. However, at some point in the future we should probably streamline all that and remove the cruft built around backwards compatibility and past solutions.
mirekdlugosz
force-pushed
the
credentials-api-v2
branch
from
2d3d196 to
c0175b1
Compare
infinitewarp
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let Camayoc use API V2 for credentials.
This is just enough changes needed to make entire Camayoc pass locally. Admittedly, this is not the best time to introduce it, as we are already in the middle of UI transition, where Camayoc is in awkward spot where it still supports old UI. If support for old UI is removed first, it will most likely conflict with changes here.
qpc tests need qpc
credentials-v2branch. Both qpc PR and that one will need to be merged close to each other, and we will have to rely on standalone jobs for tests results until then. Obviously this is not backwards-compatible, so it will wreak havoc on downstream pipeline. I would suggest to let downstream run at least few times before we merge that.See individual commits for detailed changes. I separated them to tell a story, and would prefer to merge them without squashing.