Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using data from Jenkins, add
slow
marker to all tests that on average take at least 30 seconds to complete. There are 11 tests like that. If we put threshold at 15 seconds, there would be 18 tests marked.It's important to remember that data is obtained from complete test suite runs, and so it differs from times we would obtain when running tests individually. Good example is
camayoc/tests/qpc/api/v1/reports/test_reports.py
- only first two tests gets marked, because all subsequent tests would use results cached inscans
fixture, and finish much faster. But if you were to runcamayoc/tests/qpc/api/v1/reports/test_reports.py::test_installed_products_deployment_report
individually, it would likely take long time to finish, as it would have to wait for scan to complete.Another approach we might take is just adding
slow
marker automatically to tests that usescans
fixture, leaving explicit mark to few tests that are slow due to other reasons.