Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added versions API and tests #36

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Added versions API and tests #36

merged 3 commits into from
Dec 17, 2024

Conversation

louispt1
Copy link
Collaborator

@louispt1 louispt1 commented Dec 3, 2024

Very simple API for versions, with a basic url builder. I expect this will need updating.

@louispt1 louispt1 requested a review from noracato December 3, 2024 14:38
@noracato
Copy link
Member

noracato commented Dec 6, 2024

Let's finish this one when we start to implement the version switching in model and engine. I think we need either more (model engine collections specific) or less (only tags). Probably the urls should come from the Settings, which means a lot of the logic can be incorporated into the model instead of the controller. Let's see!

@noracato noracato merged commit b6228f6 into master Dec 17, 2024
2 of 4 checks passed
@noracato noracato deleted the versions-api branch December 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants