Always set latest scenario of SavedScenario to keep_compatible

quintel · Sep 28, 2023 · aca612b · aca612b
1 parent 79d23cf
commit aca612b
Show file tree

Hide file tree

Showing 6 changed files with 188 additions and 0 deletions.
diff --git a/app/services/create_saved_scenario.rb b/app/services/create_saved_scenario.rb
@@ -40,6 +40,8 @@
     return ServiceResult.failure(saved_scenario.errors.map(&:full_message), saved_scenario)
   end
 
+  SetAPIScenarioCompatibility.keep_compatible(http_client, api_scenario.id)
+
   saved_scenario.save
   saved_scenario.scenario = api_scenario
 

diff --git a/app/services/update_saved_scenario.rb b/app/services/update_saved_scenario.rb
@@ -31,6 +31,8 @@ def call
         return failure
       end
 
+      protect
+
       ss.save
       saved_scenario.scenario = api_scenario
     end
@@ -40,6 +42,10 @@ def call
 
   private
 
+  def protect
+    SetAPIScenarioCompatibility.keep_compatible(http_client, api_scenario.id)
+  end
+
   def unprotect
     SetAPIScenarioCompatibility.dont_keep_compatible(http_client, api_scenario.id)
   end

diff --git a/...avedScenariosController/POST_create/with_valid_attributes/creates_a_new_SavedScenario.yml b/...avedScenariosController/POST_create/with_valid_attributes/creates_a_new_SavedScenario.yml
diff --git a/...s/SavedScenariosController/POST_create/with_valid_attributes/redirect_to_the_scenario.yml b/...s/SavedScenariosController/POST_create/with_valid_attributes/redirect_to_the_scenario.yml
diff --git a/...ettes/SavedScenariosController/POST_create/with_valid_attributes/sets_the_scenario_ID.yml b/...ettes/SavedScenariosController/POST_create/with_valid_attributes/sets_the_scenario_ID.yml
diff --git a/spec/services/update_saved_scenario_spec.rb b/spec/services/update_saved_scenario_spec.rb
@@ -19,6 +19,9 @@
       .and_return(api_result)
     allow(saved_scenario).to receive(:scenario)
       .and_return(ete_scenario_mock)
+    allow(client).to receive(:put).with(
+      '/api/v3/scenarios/11', scenario: { keep_compatible: true }
+    )
   end
 
   context 'when the API response is successful' do