-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various React/Next errors and warnings #12
base: main
Are you sure you want to change the base?
Conversation
Add article on design syntropy
Add prettier configuration
Add prettier and run
- Warning presented: : A title element received an array with more than 1 element as children. In browsers title Elements can only have Text Nodes as children. If the children being rendered output more than a single text node in aggregate the browser will display markup and comments as text in the title and hydration will likely fail and fall back to client rendering.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pages/about.js
Outdated
@@ -5,10 +5,12 @@ import PageHeader from "../components/page-header"; | |||
import { SITE_NAME } from "../lib/constants"; | |||
|
|||
function About() { | |||
const pageTitle = `About | ${SITE_NAME}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if these ought pull the actual page title dynamically from the content as well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. Was going to ask because you have one page that doesn't set the header on the page, just uses the Layout component, but it's the only one that does that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that's not intentional, what would you propose as an alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd update them all to use the Layout component and pass the values down. Not my project though so I didn't want to make that call without checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say go ahead and make the proposal via a PR!
No description provided.