Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various React/Next errors and warnings #12

Open
wants to merge 194 commits into
base: main
Choose a base branch
from
Open

Conversation

Taouen
Copy link
Collaborator

@Taouen Taouen commented Jul 20, 2023

No description provided.

@Taouen Taouen requested a review from quinnkeast July 20, 2023 17:22
@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quinnkeast-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 11:08pm

pages/about.js Outdated
@@ -5,10 +5,12 @@ import PageHeader from "../components/page-header";
import { SITE_NAME } from "../lib/constants";

function About() {
const pageTitle = `About | ${SITE_NAME}`;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if these ought pull the actual page title dynamically from the content as well...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. Was going to ask because you have one page that doesn't set the header on the page, just uses the Layout component, but it's the only one that does that.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that's not intentional, what would you propose as an alternative?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update them all to use the Layout component and pass the values down. Not my project though so I didn't want to make that call without checking.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say go ahead and make the proposal via a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants