proto: Refactor Endpoint.handle
#2111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endpoint::handle is still pretty long, and handle_first_packet is still reasonably small. We can make balance it out more by moving more logic into handle_first_packet.
Now that handle has been made much shorter, it's less necessary to have these large and distinctive section-dividing comments.
Endpoint.stateless_reset is called in 2 places, and both of them immediately wrap it in DatagramEvent::Response. This commit makes the stateless_reset function itself do that.
Lets us delete 4 other params.
Lets us delete 2 other params.
|
Opting to split off into more PRs instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft for now.
Main motivation:
I think
Endpoint.handleis too long. It's 173 lines and it contains section divider comments like this:The general architecture of this function dates back to a very long time ago and it used to be a lot smaller. I find it difficult to read and think it should be split up more.
Also: take opportunities to reduce LOC where found. However, some overhead is to be expected due to additional function signatures.