Unhide ecn variants #2105
Merged
Unhide ecn variants #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Ralith
requested changes
Dec 20, 2024
There was a problem hiding this comment.
I don't think we should get rid of the getters. They're a reasonably common idiom even with public variants because they're nice and terse, and the churn doesn't seem justified anyway.
Can you touch on the motivation for exposing the variants? I don't mind doing so, but I'd like to understand why.
Ah, this was discussed in the cited issue.
gretchenfrage
force-pushed
the
unhide-ecn-variants
branch
from
fcd25de to
dbeea27
Compare
gretchenfrage
force-pushed
the
unhide-ecn-variants
branch
from
dbeea27 to
a159e5c
Compare
|
Removed that commit. |
Ralith
approved these changes
Dec 20, 2024
djc
approved these changes
Dec 20, 2024
auto-merge was automatically disabled
December 20, 2024 20:49
Pull Request is not mergeable
auto-merge was automatically disabled
December 20, 2024 21:17
Pull Request is not mergeable
auto-merge was automatically disabled
December 20, 2024 21:49
Pull Request is not mergeable
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2097
I took the liberty of committing b11f2bf. Unfortunately, it is semver breaking for everything. Users must convertx.is_ce()tox == EcnCodepoint::Ce.