add Connection::send_datagram_wait #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
requested changes
Jan 15, 2024
Ralith
requested changes
Jan 15, 2024
djc
reviewed
Jan 16, 2024
devsnek
force-pushed
the
datagram-wait
branch
from
3880142 to
55376a3
Compare
|
@devsnek would you be able to split this in 3 commits, as described in my previous comment? |
|
FYI, we're planning to release 0.11.0 soon (see #1737). This includes some semver-incompatible changes in its current form, so if you'd like to get this merged it would be good to get it in a mergable state soon (per previous comments). |
djc
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1738
Not sure about the name.