Test UDP layer in isolation #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
udp-tests
branch
2 times, most recently
from
d5dc5ce to
8fa1d74
Compare
Ralith
added
help wanted
|
Need someone with a mac to investigate the failures there. Not sure how they can be going wrong when our end-to-end tests pass... |
|
Okay, it looks like it's just a bit racy. Weird. |
Ralith
force-pushed
the
udp-tests
branch
3 times, most recently
from
0fde3cd to
4635710
Compare
|
There we go, just had to set it back in blocking mode. |
Ralith
removed
help wanted
djc
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1701. Should substantially reduce risk of breakage and ease supporting new platforms.