Remove "max_tlps" configuration variable #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/no-max-tlp
branch
from
ad8faa6 to
d1efa63
Compare
It is not used since <quinn-rs#134> (commit bdc9ac7) was merged in 2018. RFC 9002 also does not mention Tail Loss Probe except that it has been integrated into the PTO (Probe Timeout) mechanism.
link2xt
force-pushed
the
link2xt/no-max-tlp
branch
from
d1efa63 to
d44e9de
Compare
|
This is technically an API-breaking change, but anyone trying to set this variable should just stop doing it as it is a no-op. This is IMO better than a misleading variable that someone might try to tweak and evaluate the results only to measure some noise. |
Ralith
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not used since
#134
(commit bdc9ac7)
was merged in 2018.
RFC 9002 also does not mention Tail Loss Probe
except that it has been integrated into the PTO (Probe Timeout)
mechanism.