Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument sharing #3035

Merged

Conversation

squaregoldfish
Copy link
Collaborator

@squaregoldfish squaregoldfish merged commit 0a42813 into quince-science:master Dec 13, 2024
2 checks passed
@squaregoldfish squaregoldfish deleted the 137-instrument-ownership branch December 13, 2024 12:19
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 6.88073% with 203 lines in your changes missing coverage. Please review.

Project coverage is 29.90%. Comparing base (d622469) to head (4b96e96).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ac/exeter/QuinCe/data/Instrument/InstrumentDB.java 15.29% 70 Missing and 2 partials ⚠️
...eter/QuinCe/web/Instrument/InstrumentListBean.java 0.00% 62 Missing ⚠️
...k/ac/exeter/QuinCe/data/Instrument/Instrument.java 3.70% 26 Missing ⚠️
WebApp/src/uk/ac/exeter/QuinCe/User/UserDB.java 0.00% 20 Missing ⚠️
WebApp/src/uk/ac/exeter/QuinCe/User/User.java 0.00% 11 Missing ⚠️
...p/src/uk/ac/exeter/QuinCe/web/BaseManagedBean.java 14.28% 6 Missing ⚠️
...c/exeter/QuinCe/web/Instrument/BeanInstrument.java 0.00% 5 Missing ⚠️
...eb/Instrument/newInstrument/NewInstrumentBean.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3035      +/-   ##
============================================
- Coverage     30.15%   29.90%   -0.25%     
- Complexity     2112     2113       +1     
============================================
  Files           393      394       +1     
  Lines         20280    20492     +212     
  Branches       2759     2780      +21     
============================================
+ Hits           6115     6129      +14     
- Misses        13702    13898     +196     
- Partials        463      465       +2     
Flag Coverage Δ
unittests 29.90% <6.88%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant