1884 Work out how to trigger reprocessing of datasets with multiple calibration edits #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- NB TESTS ARE BROKEN - Allow Sensor Calibrations and External Standards to change within a DataSet (not CalculationCoefficients) - Main logic of Calibration editing complete (untested, likely broken)
…of-datasets-with-multiple-calibration-edits
There's too many tests now. They can still be running manually after a git fetch/git pull.
…of-datasets-with-multiple-calibration-edits
…of-datasets-with-multiple-calibration-edits
Sensor Calibrations included in manifest
Now matches the one used in the instruments list
Standards included in export manifest Reference values shown properly on plots Data reduction confirmed to work
Also fix all references to ID_PARAM in jobs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3026 +/- ##
============================================
+ Coverage 29.28% 30.15% +0.86%
- Complexity 2009 2112 +103
============================================
Files 389 393 +4
Lines 20068 20279 +211
Branches 2724 2759 +35
============================================
+ Hits 5877 6115 +238
+ Misses 13760 13701 -59
- Partials 431 463 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
squaregoldfish
deleted the
1884-work-out-how-to-trigger-reprocessing-of-datasets-with-multiple-calibration-edits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1884
Fix #2985