Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper links to modify configs #4273

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Helper links to modify configs #4273

wants to merge 13 commits into from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Dec 27, 2024

  • Added "Add quilt_summarize" button when quilt_summarize.json is not present inside a package
  • Added a link to the bucket config from bucket admin page

Screenshot from 2024-12-30 11-32-27

Screenshot from 2024-12-30 11-33-22

  • Unit tests
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes missing coverage. Please review.

Project coverage is 38.60%. Comparing base (2272102) to head (bca6c39).

Files with missing lines Patch % Lines
catalog/app/containers/Admin/Buckets/Buckets.tsx 0.00% 5 Missing ⚠️
catalog/app/containers/Bucket/Summary.js 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4273      +/-   ##
==========================================
+ Coverage   38.35%   38.60%   +0.24%     
==========================================
  Files         778      778              
  Lines       34366    34395      +29     
  Branches     5219     5430     +211     
==========================================
+ Hits        13180    13277      +97     
+ Misses      20643    19939     -704     
- Partials      543     1179     +636     
Flag Coverage Δ
api-python 91.34% <ø> (ø)
catalog 17.25% <81.08%> (+0.37%) ⬆️
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus changed the title Config buttons Helper links to modify configs Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant