Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about auto-adding source bucket #4258

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Dec 11, 2024

  • Documentation

@fiskus fiskus requested a review from drernie December 11, 2024 10:10
@fiskus fiskus mentioned this pull request Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.59%. Comparing base (cda3d76) to head (c9b6ee2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4258    +/-   ##
========================================
  Coverage   37.59%   37.59%            
========================================
  Files         769      769            
  Lines       33984    33984            
  Branches     5156     5361   +205     
========================================
  Hits        12775    12775            
+ Misses      20665    20022   -643     
- Partials      544     1187   +643     
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 15.61% <ø> (ø)
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drernie
Copy link
Member

drernie commented Dec 12, 2024

Will this work even if the user is not an Administrator, as long as they can write to the bucket?

@fiskus fiskus requested a review from drernie December 12, 2024 10:26
@fiskus
Copy link
Member Author

fiskus commented Dec 12, 2024

Yes, I've just created a new non-admin user with ReadWriteQUuiltBucket role and the feature works for this user.

@fiskus fiskus added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit ea89fb9 Dec 13, 2024
37 checks passed
@fiskus fiskus deleted the docs-auto-add-source-bucket branch December 13, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants