Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "html" in quilt_summarize.json #4252

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Dec 3, 2024

This is a quick fix. I've started to work on a more general solution, but this small piece, I think, self-sustainable.

More scalable solutions require more involvement, but I have several ideas already:

  • enable everything we have Previews for
  • make "name" optional, and treat it like fallback type
  • improve JsonEditor, so users can create with config with some helper and make "name" a plain string but with select from supported types
  • make custom editor for writing quilt_summarize.json
  • or, change (make v2) Schema (but I'd go with custom editor first, so customers wouldn't care about Schema)
  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.60%. Comparing base (207546e) to head (8c33976).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4252   +/-   ##
=======================================
  Coverage   37.60%   37.60%           
=======================================
  Files         769      769           
  Lines       33993    33993           
  Branches     5361     5361           
=======================================
  Hits        12784    12784           
  Misses      20022    20022           
  Partials     1187     1187           
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 15.64% <ø> (ø)
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus marked this pull request as ready for review December 3, 2024 14:29
@fiskus fiskus requested a review from nl0 December 3, 2024 14:36
nl0
nl0 previously approved these changes Dec 3, 2024
catalog/CHANGELOG.md Outdated Show resolved Hide resolved
@fiskus fiskus added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit cda3d76 Dec 3, 2024
37 checks passed
@fiskus fiskus deleted the enable-html-styling-for-summarize branch December 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants