Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lambdas to Python 3.11 #4241

Merged
merged 47 commits into from
Dec 3, 2024
Merged

update lambdas to Python 3.11 #4241

merged 47 commits into from
Dec 3, 2024

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Nov 27, 2024

Description

changes:

  • add explicit deps for t4_lambda_shared
  • add explicit dep on t4_lambda_shared in lambdas
  • update all lambdas to Python 3.11 (except thumbnail)
  • regenerate/update all requirements.txt with pip-compile
  • add test-requirements.in and regenerate test-requirements.txt for every lambda
  • clean up deps installation in test CI job
  • stop passing shared to builder context
  • add missing changelogs

notes

  • dep on t4_lambda_shared is specified using hash from this PR, it doesn't looks like t4_lambda_shared changes can be made as separate PR, so hash needs to be updated after PR
  • molecule lambda is not really used, so I haven't tested it manually, maybe makes sense to remove it? removed

TODO

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.60%. Comparing base (a73deba) to head (6dce576).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4241      +/-   ##
==========================================
- Coverage   39.71%   37.60%   -2.12%     
==========================================
  Files         779      769      -10     
  Lines       35336    33993    -1343     
  Branches     5156     5156              
==========================================
- Hits        14035    12784    -1251     
+ Misses      20757    20665      -92     
  Partials      544      544              
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 15.64% <ø> (ø)
lambda 91.48% <100.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sir-sigurd sir-sigurd requested a review from nl0 November 29, 2024 12:16
nl0
nl0 previously approved these changes Nov 29, 2024
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so much cleaner

@nl0
Copy link
Member

nl0 commented Nov 29, 2024

molecule lambda is not really used, so I haven't tested it manually, maybe makes sense to remove it?

yeah probably. maybe in a clean PR?

@sir-sigurd sir-sigurd marked this pull request as ready for review December 3, 2024 09:39
@sir-sigurd sir-sigurd requested a review from nl0 December 3, 2024 09:39
nl0
nl0 previously approved these changes Dec 3, 2024
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.github/workflows/deploy-lambdas.yaml Outdated Show resolved Hide resolved
@sir-sigurd sir-sigurd added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit d496dff Dec 3, 2024
36 of 37 checks passed
@sir-sigurd sir-sigurd deleted the lambdas-3.11 branch December 3, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants