-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog: Replace S3 Select with GQL #4218
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4218 +/- ##
==========================================
+ Coverage 39.02% 39.22% +0.19%
==========================================
Files 772 780 +8
Lines 35540 35493 -47
Branches 5111 5293 +182
==========================================
+ Hits 13870 13922 +52
+ Misses 21063 20375 -688
- Partials 607 1196 +589
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@fiskus this is deployed on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I'm glad gql and typescript coverage is increasing.
I still have some concerns over using Effect. Sometimes it seems that code with Effect is more complicated than without. I experimented with it a little, and will show you what I found later.
for trivial cases -- maybe.
i'm curious to see your findings |
This reverts commit 7b57360.
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 14 out of 27 changed files in this pull request and generated 1 suggestion.
Files not reviewed (13)
- catalog/app/containers/Bucket/File/gql/ObjectAccessCounts.graphql: Language not supported
- catalog/app/containers/Bucket/Overview/gql/BucketAccessCounts.graphql: Language not supported
- catalog/app/embed/File.js: Evaluated as low risk
- catalog/app/containers/Bucket/File/AssistantContext.ts: Evaluated as low risk
- catalog/app/containers/Bucket/File/File.js: Evaluated as low risk
- catalog/CHANGELOG.md: Evaluated as low risk
- catalog/app/containers/Bucket/Overview/gql/BucketConfig.generated.ts: Evaluated as low risk
- catalog/app/containers/Bucket/Summarize.tsx: Evaluated as low risk
- catalog/app/containers/Bucket/requests/requestsUntyped.js: Evaluated as low risk
- catalog/app/model/graphql/types.generated.ts: Evaluated as low risk
- catalog/app/model/graphql/schema.generated.ts: Evaluated as low risk
- catalog/app/containers/Bucket/File/index.ts: Evaluated as low risk
- catalog/app/containers/Bucket/Overview/index.tsx: Evaluated as low risk
Changes
Checklist