-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using S3 Select in indexer #4212
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4212 +/- ##
==========================================
- Coverage 39.02% 39.01% -0.02%
==========================================
Files 772 772
Lines 35540 35552 +12
Branches 5311 5111 -200
==========================================
+ Hits 13870 13871 +1
- Misses 20444 21074 +630
+ Partials 1226 607 -619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- lambdas/indexer/pytest.ini: Language not supported
- lambdas/indexer/test-requirements.txt: Language not supported
Comments skipped due to low confidence (1)
lambdas/indexer/index.py:511
- [nitpick] The error message 'DuckDB select error' is vague. Consider providing more context or details in the error message.
logger_.error("DuckDB select error: %s", parsed["error"])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see anything suspicious
Co-authored-by: Alexei Mochalov <[email protected]>
Description
TODO