Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using S3 Select in indexer #4212

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Stop using S3 Select in indexer #4212

merged 12 commits into from
Nov 19, 2024

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Nov 8, 2024

Description

TODO

  • revert CI
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 36.11111% with 23 lines in your changes missing coverage. Please review.

Project coverage is 39.01%. Comparing base (6d70cc8) to head (18bee5a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lambdas/indexer/index.py 32.35% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4212      +/-   ##
==========================================
- Coverage   39.02%   39.01%   -0.02%     
==========================================
  Files         772      772              
  Lines       35540    35552      +12     
  Branches     5311     5111     -200     
==========================================
+ Hits        13870    13871       +1     
- Misses      20444    21074     +630     
+ Partials     1226      607     -619     
Flag Coverage Δ
api-python 91.09% <ø> (ø)
catalog 14.30% <ø> (ø)
lambda 87.75% <36.11%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sir-sigurd sir-sigurd requested a review from nl0 November 15, 2024 17:17
@sir-sigurd sir-sigurd marked this pull request as ready for review November 15, 2024 17:17
@nl0 nl0 requested a review from Copilot November 18, 2024 12:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 6 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • lambdas/indexer/pytest.ini: Language not supported
  • lambdas/indexer/test-requirements.txt: Language not supported
Comments skipped due to low confidence (1)

lambdas/indexer/index.py:511

  • [nitpick] The error message 'DuckDB select error' is vague. Consider providing more context or details in the error message.
logger_.error("DuckDB select error: %s", parsed["error"])
nl0
nl0 previously approved these changes Nov 18, 2024
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see anything suspicious

@sir-sigurd sir-sigurd added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 40db3b4 Nov 19, 2024
37 of 40 checks passed
@sir-sigurd sir-sigurd deleted the indexer-duckdb-select branch November 19, 2024 11:16
sir-sigurd added a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants