Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some doc URLs in catalog #4205

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Fix some doc URLs in catalog #4205

merged 15 commits into from
Nov 19, 2024

Conversation

sir-sigurd
Copy link
Member

It looks like URLs were changed by c5edede. There are redirects to new locations but URL fragment is not preserved after redirect.

This change is mostly to fix URLs with fragments, others are updated for uniformity.

It looks like URLs were changed by c5edede.
There are redirects to new locations but URL fragment is not preserved after
redirect.

This change is mostly to fix URLs with fragments, others are updated for uniformity.
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.21%. Comparing base (8dd6815) to head (7382d51).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4205    +/-   ##
========================================
  Coverage   39.21%   39.21%            
========================================
  Files         780      780            
  Lines       35505    35505            
  Branches     5092     5293   +201     
========================================
  Hits        13923    13923            
+ Misses      21016    20386   -630     
- Partials      566     1196   +630     
Flag Coverage Δ
api-python 91.09% <ø> (ø)
catalog 14.54% <ø> (ø)
lambda 87.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sir-sigurd sir-sigurd requested review from drernie and fiskus October 30, 2024 11:54
@drernie
Copy link
Member

drernie commented Oct 31, 2024

Ouch, sorry about that. Fixes approved.

drernie
drernie previously approved these changes Oct 31, 2024
@sir-sigurd sir-sigurd marked this pull request as ready for review November 12, 2024 12:41
nl0
nl0 previously approved these changes Nov 14, 2024
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. a changelog would be nice

@drernie
Copy link
Member

drernie commented Nov 18, 2024

@sir-sigurd Are you just needing to add the CHANGELOG?

fiskus and others added 8 commits November 19, 2024 12:25
…better loading/error visuals) (#4208)

Co-authored-by: Alexei Mochalov <[email protected]>
…roxy (#4222)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dr. Ernie Prabhakar <[email protected]>
Co-authored-by: Dr. Ernie Prabhakar <[email protected]>
…log (#4220)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sir-sigurd sir-sigurd dismissed stale reviews from nl0 and drernie via 3dc7a58 November 19, 2024 11:25
@sir-sigurd sir-sigurd requested a review from nl0 November 19, 2024 11:27
@sir-sigurd sir-sigurd changed the title Fix doc URLs in catalog Fix some doc URLs in catalog Nov 19, 2024
@nl0 nl0 enabled auto-merge November 19, 2024 13:34
@nl0 nl0 added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 2eb3cfc Nov 19, 2024
41 checks passed
@nl0 nl0 deleted the catalog-fix-uris branch November 19, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants