access counts gql #4202
access counts gql #4202
Conversation
| @@ -215,13 +215,24 @@ type User { | |||
| type AccessCountForDate { | |||
| date: Datetime! | |||
| value: Int! | |||
| sum: Int! # running sum | |||
There was a problem hiding this comment.
not sure this is required, since it can be easily calculated on the consuming side, but it feels quite convenient to have this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4202 +/- ##
=======================================
Coverage 37.69% 37.69%
=======================================
Files 768 768
Lines 35317 35317
Branches 5215 5215
=======================================
Hits 13313 13313
Misses 20769 20769
Partials 1235 1235
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| type BucketAccessCounts { | ||
| byExt(groups: Int): AccessCountsGroup[] |
There was a problem hiding this comment.
don't merge / collapse the groups by default
(maybe we don't have to do that at all, just keep that logic on the front-end, not sure)
There was a problem hiding this comment.
I'm not quite sure what you mean
There was a problem hiding this comment.
catalog code "collapses" access counts into a finite number of "bands", so if there's too many extensions, less frequent ones are merged into a single "other" band.
this proposed api design assumes there's no such collapsing performed by default (when groups are null or zero)
| @@ -556,6 +567,9 @@ type Query { | |||
| searchMorePackages(after: String!, size: Int = 30): PackagesSearchMoreResult! | |||
| subscription: SubscriptionState! | |||
|
|
|||
| bucketAccessCounts(bucket: String!, window: Int!): BucketAccessCounts | |||
| objectAccessCounts(bucket: String!, key: String!, window: Int!): AccessCounts | |||
There was a problem hiding this comment.
we don't have a proper "bucket" entry point currently, and i don't feel comfortable designing / adding that now, so let's just add separate queries.
tho feel free to add a simple container type to group this if you like
sir-sigurd
force-pushed
the
access-counts-gql
branch
from
994da13 to
d32fd6f
Compare
|
I guess this can be closed now |
Description
TODO
optipngon any new PNGsbuild.pyfor new docstrings