Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show release version in Footer #4200

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Show release version in Footer #4200

merged 10 commits into from
Nov 5, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Oct 22, 2024

  • Get stackVersion from /config.js and show it in a footer

Also:

  • Converted Notification.js and Footer.js to typescript
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 37.68%. Comparing base (7972243) to head (b0d92f6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
catalog/app/components/Footer/Footer.tsx 0.00% 7 Missing ⚠️
...alog/app/containers/Notifications/Notification.tsx 0.00% 7 Missing ⚠️
catalog/app/components/Layout/Layout.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4200      +/-   ##
==========================================
- Coverage   37.69%   37.68%   -0.01%     
==========================================
  Files         768      768              
  Lines       35317    35321       +4     
  Branches     5215     5214       -1     
==========================================
- Hits        13313    13312       -1     
- Misses      20769    20775       +6     
+ Partials     1235     1234       -1     
Flag Coverage Δ
api-python 91.09% <ø> (ø)
catalog 12.07% <0.00%> (-0.01%) ⬇️
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus changed the title Get stack.version from GraphQL, show it in a footer; keep git revision for sentry and tracking Show release version in Footer Oct 22, 2024
@fiskus fiskus marked this pull request as ready for review October 22, 2024 16:46
@fiskus fiskus requested a review from nl0 October 22, 2024 17:22
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd go with the config.js approach for the sake of simplicity.
it's kinda debatable whether this data belongs to the config conceptually, but i think it's an okay compromise in this specific case

catalog/app/components/Layout/Layout.tsx Outdated Show resolved Hide resolved
@fiskus fiskus requested a review from nl0 November 5, 2024 11:42
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some nitpicks inline

catalog/app/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
catalog/config-schema.json Outdated Show resolved Hide resolved
catalog/config-schema.json Outdated Show resolved Hide resolved
catalog/app/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
catalog/config-schema.json Outdated Show resolved Hide resolved
@fiskus fiskus requested a review from nl0 November 5, 2024 12:00
catalog/config-schema.json Show resolved Hide resolved
catalog/app/utils/Config.ts Show resolved Hide resolved
@fiskus fiskus requested a review from nl0 November 5, 2024 12:26
nl0
nl0 previously approved these changes Nov 5, 2024
catalog/config.js.example Outdated Show resolved Hide resolved
Co-authored-by: Alexei Mochalov <[email protected]>
@fiskus fiskus added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit 22cfedd Nov 5, 2024
38 of 40 checks passed
@fiskus fiskus deleted the stack-version branch November 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants