-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show release version in Footer
#4200
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4200 +/- ##
==========================================
- Coverage 37.69% 37.68% -0.01%
==========================================
Files 768 768
Lines 35317 35321 +4
Branches 5215 5214 -1
==========================================
- Hits 13313 13312 -1
- Misses 20769 20775 +6
+ Partials 1235 1234 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd go with the config.js approach for the sake of simplicity.
it's kinda debatable whether this data belongs to the config conceptually, but i think it's an okay compromise in this specific case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some nitpicks inline
Co-authored-by: Alexei Mochalov <[email protected]>
Co-authored-by: Alexei Mochalov <[email protected]>
stackVersion
from/config.js
and show it in a footerAlso: