Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-shared: cross-region chunksums support (pass scratch bucket map to lambdas) #3922

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Mar 26, 2024

Changes required for cross-region chunksums (passing the scratch bucket map to the lambdas):

  • Add scratch_buckets required field to S3HashLambdaParams
  • Introduce PackageConstructParams

TODO

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.58%. Comparing base (2edbba0) to head (2c50da7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3922   +/-   ##
=======================================
  Coverage   36.58%   36.58%           
=======================================
  Files         719      719           
  Lines       31980    31980           
  Branches     4707     4707           
=======================================
  Hits        11700    11700           
  Misses      19116    19116           
  Partials     1164     1164           
Flag Coverage Δ
api-python 90.89% <ø> (ø)
catalog 10.61% <ø> (ø)
lambda 87.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nl0 nl0 changed the title Cross-region chunksums: py-shared py-shared: cross-region chunksums support (passing scratch bucket map to lambdas) Apr 4, 2024
@nl0 nl0 marked this pull request as ready for review April 4, 2024 12:10
@nl0 nl0 requested a review from sir-sigurd April 4, 2024 12:10
@nl0 nl0 changed the title py-shared: cross-region chunksums support (passing scratch bucket map to lambdas) py-shared: cross-region chunksums support (pass scratch bucket map to lambdas) Apr 4, 2024
@nl0 nl0 added this pull request to the merge queue Apr 4, 2024
Merged via the queue into master with commit 7c6edd1 Apr 4, 2024
40 checks passed
@nl0 nl0 deleted the shared-scratch-buckets branch April 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants