Resetted nodes were briefly identified as alive. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is that we call report_heartbeat in the reset procedure. The purpose of this call is to make sure that we have a record in the failure detector for the node. This PR just creates the failure detector entry, and avoid recording a heartbeat change. This PR also makes sure we do not count the first heartbeat record as an event. Closes #132
fulmicoton
requested review from
trinity-1686a and
guilload
and removed request for
trinity-1686a
guilload
approved these changes
Feb 28, 2024
fulmicoton
deleted the
issue/132-bugfix-resetted-nodes-marked-as-alive-b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason is that we call report_heartbeat in the reset procedure. The purpose of this call is to make sure that we have a record in the failure detector for the node.
This PR just creates the failure detector entry, and avoid recording a heartbeat change.
This PR also makes sure we do not count the first heartbeat record as an event.
Closes #132