Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fix and enable connection migration tests #410

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: Fix and enable connection migration tests #410

wants to merge 11 commits into from

Conversation

larseggert
Copy link
Contributor

No description provided.

mxinden
mxinden reviewed Oct 16, 2024
View reviewed changes
testcases.py Show resolved Hide resolved
@larseggert
Copy link
Contributor Author

Screenshot 2024-11-04 at 14 58 43

@larseggert
Copy link
Contributor Author

@marten-seemann this is ready from my side.

@larseggert
Copy link
Contributor Author

@marten-seemann conflict is resolved.

@larseggert larseggert mentioned this pull request Nov 11, 2024
Merged
@mxinden
Copy link
Contributor

mxinden commented Dec 16, 2024

@larseggert @marten-seemann I assume this is still worth merging?

@PiotrSikora
Copy link

FYI, using this branch with ghcr.io/mozilla/neqo-qns@3d9351310775 doesn't fix those tests for me:

~/quic-interop-runner$ ./run.py --client neqo --server neqo --test rebind-port,rebind-addr,connectionmigration
Saving logs to logs_2024-12-16T13:47:18.
Server: neqo. Client: neqo. Running test case: rebind-port
First server packet on new path (('193.167.100.100', 443), ('193.167.0.100', 57607)) did not contain a PATH_CHALLENGE frame
Layer QUIC
:       QUIC Connection information
        Expert Info (Note/Protocol): Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Severity level: Note
        Group: Protocol
        Packet Length: 27
        QUIC Short Header
        0... .... = Header Form: Short Header (0)
        .1.. .... = Fixed Bit: True
        ..0. .... = Spin Bit: False
        Remaining Payload: eb2b35fd069b454771d4d5e4fd39a8a4ba0bd1dda2b803ce7148

Server: neqo. Client: neqo. Running test case: rebind-addr
At least one QUIC packet could not be decrypted
First server packet on new path (('193.167.100.100', 443), ('193.167.0.224', 59022)) did not contain a PATH_CHALLENGE frame
Layer QUIC
:       QUIC Connection information
        Expert Info (Note/Protocol): Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Severity level: Note
        Group: Protocol
        Packet Length: 27
        QUIC Short Header
        0... .... = Header Form: Short Header (0)
        .0.. .... = Fixed Bit: False
        ..1. .... = Spin Bit: True
        Remaining Payload: a761a55f7de9efd6426cb682a15da8fdb421917c52c7a905bb56

At least one QUIC packet could not be decrypted
Server saw these client addresses: {'193.167.0.3', '193.167.0.100', '193.167.0.224', '193.167.0.71'}
At least one QUIC packet could not be decrypted
First server packet on new path (('193.167.100.100', 443), ('193.167.0.224', 59022)) did not contain a PATH_CHALLENGE frame
Layer QUIC
:       QUIC Connection information
        Expert Info (Note/Protocol): Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Severity level: Note
        Group: Protocol
        Packet Length: 27
        QUIC Short Header
        0... .... = Header Form: Short Header (0)
        .0.. .... = Fixed Bit: False
        ..1. .... = Spin Bit: True
        Remaining Payload: a761a55f7de9efd6426cb682a15da8fdb421917c52c7a905bb56

Server: neqo. Client: neqo. Running test case: connectionmigration
First server packet on new path (('fd00:cafe:cafe:100::100', 4443), ('fd00:cafe:cafe::100', 34845)) did not contain a PATH_CHALLENGE frame
Layer QUIC
:       QUIC Connection information
        Expert Info (Note/Protocol): Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Severity level: Note
        Group: Protocol
        Packet Length: 1232
        QUIC Short Header
        0... .... = Header Form: Short Header (0)
        .0.. .... = Fixed Bit: False
        ..0. .... = Spin Bit: False
        Remaining Payload: e3678bf3e8f6161e0d4c19bc5b3f81094ee54443d31cab012f1c631b139fef9358a1689f…

Server saw these client addresses: {'fd00:cafe:cafe::100'}
Server saw only a single client IP address in use; test broken?
First server packet on new path (('fd00:cafe:cafe:100::100', 4443), ('fd00:cafe:cafe::100', 34845)) did not contain a PATH_CHALLENGE frame
Layer QUIC
:       QUIC Connection information
        Expert Info (Note/Protocol): Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Unknown QUIC connection. Missing Initial Packet or migrated connection?
        Severity level: Note
        Group: Protocol
        Packet Length: 1232
        QUIC Short Header
        0... .... = Header Form: Short Header (0)
        .0.. .... = Fixed Bit: False
        ..0. .... = Spin Bit: False
        Remaining Payload: e3678bf3e8f6161e0d4c19bc5b3f81094ee54443d31cab012f1c631b139fef9358a1689f…

Server saw these client addresses: {'fd00:cafe:cafe::100'}
Server saw only a single client IP address in use; test broken?
Run took 0:02:34.886099
+------+-------------+
|      |     neqo    |
+------+-------------+
| neqo |     ✓()     |
|      |     ?()     |
|      | ✕(BP,BA,CM) |
+------+-------------+

Also, s2n-quic has an alternative patch (https://github.com/aws/s2n-quic/blob/main/.github/interop/runner.patch) for those tests, and the rebinding tests are passing for me across multiple implementations when using it.

@larseggert
Copy link
Contributor Author

Those Wireshark messages probably mean you have a version installed that is too old.

@PiotrSikora
Copy link

Those Wireshark messages probably mean you have a version installed that is too old.

$ tshark -v
TShark (Wireshark) 4.0.17 (Git v4.0.17 packaged as 4.0.17-0+deb12u1).
$ editcap -v
Editcap (Wireshark) 4.0.17 (Git v4.0.17 packaged as 4.0.17-0+deb12u1).

Isn't that recent enough? README.md says 3.5.0+... Although, I'm not sure what the "development version" refers to, I suspect it's a leftover from before 4.x stable release?

@larseggert
Copy link
Contributor Author

Those are too old. I use TShark (Wireshark) 4.5.0rc0-830-g10cc65f41321 (v4.5.0rc0-830-g10cc65f41321). at the moment.

@PiotrSikora
Copy link

Thanks, that helped!

However, even with tshark built from the same commit as yours (10cc65f413214ee66ea0d2a3cb04c6ef65bad079), the connection migration test still fails for me:

$ ./run.py --client neqo --server neqo --test rebind-port,rebind-addr,connectionmigration
Saving logs to logs_2024-12-17T03:40:19.
Server: neqo. Client: neqo. Running test case: rebind-port
Server saw these paths used: {(('193.167.100.100', 443), ('193.167.0.100', 44827)), (('193.167.100.100', 443), ('193.167.0.100', 57607)), (('193.167.100.100', 443), ('193.167.0.100', 59022))}
Server: neqo. Client: neqo. Running test case: rebind-addr
Server saw these paths used: {(('193.167.100.100', 443), ('193.167.0.224', 59022)), (('193.167.100.100', 443), ('193.167.0.71', 39968)), (('193.167.100.100', 443), ('193.167.0.100', 55795)), (('193.167.100.100', 443), ('193.167.0.3', 38910))}
Server saw these client addresses: {'193.167.0.100', '193.167.0.71', '193.167.0.224', '193.167.0.3'}
Server saw these paths used: {(('193.167.100.100', 443), ('193.167.0.224', 59022)), (('193.167.100.100', 443), ('193.167.0.71', 39968)), (('193.167.100.100', 443), ('193.167.0.100', 55795)), (('193.167.100.100', 443), ('193.167.0.3', 38910))}
Server: neqo. Client: neqo. Running test case: connectionmigration
Server saw these paths used: {(('fd00:cafe:cafe:100::100', 443), ('fd00:cafe:cafe::100', 43132)), (('fd00:cafe:cafe:100::100', 4443), ('fd00:cafe:cafe::100', 43132))}
Server saw these client addresses: {'fd00:cafe:cafe::100'}
Server saw only a single client IP address in use; test broken?
Server saw these paths used: {(('fd00:cafe:cafe:100::100', 443), ('fd00:cafe:cafe::100', 43132)), (('fd00:cafe:cafe:100::100', 4443), ('fd00:cafe:cafe::100', 43132))}
Server saw these client addresses: {'fd00:cafe:cafe::100'}
Server saw only a single client IP address in use; test broken?
Run took 0:02:57.550582
+------+----------+
|      |   neqo   |
+------+----------+
| neqo | ✓(BP,BA) |
|      |   ?()    |
|      |  ✕(CM)   |
+------+----------+

Note that the connection migration test is using IPv6, and not IPv4 like the rebinding tests (which are passing now), so perhaps the issue is elsewhere?

PiotrSikora
PiotrSikora reviewed Dec 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@larseggert @PiotrSikora
Update README.md
cde2270 
Co-authored-by: Piotr Sikora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora left review comments

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larseggert @mxinden @PiotrSikora