Expose timm constructor arguments #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qubvel @adamjstewart I kind of need this, and the community appears to do so as well. What is missing to make it land? |
qubvel
reviewed
Nov 4, 2024
Comment on lines
53
to
58
| def _merge_kwargs_no_dupls(a: dict[str, Any], b: dict[str, Any]) -> dict[str, Any]: | ||
| dupls = a.keys() & b.keys() | ||
| if dupls: | ||
| raise ValueError(f"'{dupls}' already specified internally") | ||
|
|
||
| return a | b |
There was a problem hiding this comment.
Let's refactor it a bit:
- dupls -> duplicates
- "|" not sure which python version introduced it, maybe
{**a, **b}would be more robust
There was a problem hiding this comment.
- Looks like it was added in Python 3.9, so no need to change this: https://peps.python.org/pep-0584/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #954