-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyedit security-cors.adoc #44755
base: main
Are you sure you want to change the base?
Copyedit security-cors.adoc #44755
Conversation
2856241
to
afb52c1
Compare
🎊 PR Preview d4cbdb2 has been successfully built and deployed to https://quarkus-pr-main-44755-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
afb52c1
to
b06227e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sberyozkin. Please let me know if we can make further improvements!
3eb86b1
to
43e9552
Compare
This comment has been minimized.
This comment has been minimized.
Didn't we already discuss the fact that we wanted to avoid large backports to 3.15 after the first release, included in doc? Is there any particular reason why this PR has the |
Hi @gsmet, Thank you for pointing this out. I realize now the backport/3.15 label doesn’t apply, and I’ve removed it—apologies for any disruption this caused. I added it because I’m working to downstream security docs for Keycloak, JWT, and CORS (about five files) into 3.15.x product documentation but misunderstood the guidelines around large backports. Would it be possible for me to cherry-pick these PRs into the 3.15 branch manually? If not, I’ll coordinate with Sangeeta next week to explore other options. Best regards, |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rolfedh for improving the doc
@rolfedh Hi Rolfe, PR has a merge commit: |
bae368c
to
6d99105
Compare
Status for workflow
|
Improve style and clarity.