Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration property to container-based datasource devservices for capturing logs with JBossLoggingConsumer #44375

Merged

Conversation

DeMol-EE
Copy link
Contributor

@DeMol-EE DeMol-EE commented Nov 7, 2024

Brings support for JBossLoggingConsumer (following #43809) to container-based datasource dev services, and adds a little section to the documentation about the new "showLogs" option.

Also contains a minor correction to the AppCDS documentation.

I ran MAVEN_OPTS="-Xmx4g" ./mvnw -Dquickly followed by ./mvnw install -f extensions/devservices/ but have honestly no idea if this will work. Is there an easy way to test this locally? Should I "mvn install" the entire quarkus repo locally, make a tiny quarkus app, and update the bom version to 999-SNAPSHOT to verify this?

Copy link

quarkus-bot bot commented Nov 7, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

This comment has been minimized.

Copy link

github-actions bot commented Nov 7, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@DeMol-EE DeMol-EE force-pushed the datasource-devservices-showLogs-squashed branch from c23d0f2 to b2b2a60 Compare November 8, 2024 04:42
@DeMol-EE DeMol-EE changed the title datasource devservices: showLogs Add configuration property to container-based datasource devservices for capturing logs with JBossLoggingConsumer Nov 8, 2024
@DeMol-EE
Copy link
Contributor Author

DeMol-EE commented Nov 8, 2024

@gastaldi based on the example you provided earlier, I wanted to bring JBossLoggingConsumer to container-based datasource dev services. Would you be willing to review this PR?

This comment has been minimized.

This comment has been minimized.

@DeMol-EE DeMol-EE force-pushed the datasource-devservices-showLogs-squashed branch from b2b2a60 to 611f5e0 Compare November 8, 2024 07:37

This comment has been minimized.

This comment has been minimized.

@geoand geoand requested a review from gastaldi November 11, 2024 15:20
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be optional, as we can assume false by default

This comment has been minimized.

This comment has been minimized.

@DeMol-EE DeMol-EE force-pushed the datasource-devservices-showLogs-squashed branch from d1394b6 to 196c0f9 Compare November 12, 2024 07:59
@quarkus-bot quarkus-bot bot added area/adr area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/keycloak area/kubernetes area/logging area/narayana Transactions / Narayana labels Nov 12, 2024
@gastaldi gastaldi force-pushed the datasource-devservices-showLogs-squashed branch from c48ee0e to eb3c31b Compare November 12, 2024 13:32
@gastaldi
Copy link
Contributor

@DeMol-EE I fixed your commit, it's good to be merged after CI passes

@gastaldi gastaldi added triage/waiting-for-ci Ready to merge when CI successfully finishes area/devservices area/jdbc Issues related to the JDBC extensions and removed area/jbang Issues related to when using jbang.dev with Quarkus area/core area/resteasy-classic area/logging area/smallrye area/vertx area/scheduler area/rest-client area/openapi area/oidc area/narayana Transactions / Narayana area/kubernetes area/dependencies Pull requests that update a dependency file area/qute The template engine area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/tracing area/rest area/adr area/keycloak labels Nov 12, 2024
@DeMol-EE
Copy link
Contributor Author

Thanks @gastaldi and sorry for the delays

Copy link

quarkus-bot bot commented Nov 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit eb3c31b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Nov 12, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit eb3c31b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.metrics.HttpServerMetricsTest.collectsHttpRouteFromEndAttributes - History

  • Assertion condition defined as a Lambda expression in io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter expected: <true> but was: <false> within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter expected: <true> but was: <false> within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter.assertCountPointsAtLeast(InMemoryMetricExporter.java:131)
	at io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter_ClientProxy.assertCountPointsAtLeast(Unknown Source)
  • Assertion condition defined as a Lambda expression in io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter expected: <true> but was: <false> within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter expected: <true> but was: <false> within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter.assertCountPointsAtLeast(InMemoryMetricExporter.java:131)
	at io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter_ClientProxy.assertCountPointsAtLeast(Unknown Source)

@gastaldi gastaldi merged commit 0c5417f into quarkusio:main Nov 12, 2024
48 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 12, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants