-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration property to container-based datasource devservices for capturing logs with JBossLoggingConsumer #44375
Add configuration property to container-based datasource devservices for capturing logs with JBossLoggingConsumer #44375
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
c23d0f2
to
b2b2a60
Compare
@gastaldi based on the example you provided earlier, I wanted to bring JBossLoggingConsumer to container-based datasource dev services. Would you be willing to review this PR? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b2b2a60
to
611f5e0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...tasource/runtime/src/main/java/io/quarkus/datasource/runtime/DevServicesBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to be optional, as we can assume false
by default
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d1394b6
to
196c0f9
Compare
c48ee0e
to
eb3c31b
Compare
@DeMol-EE I fixed your commit, it's good to be merged after CI passes |
Thanks @gastaldi and sorry for the delays |
Status for workflow
|
Status for workflow
|
Brings support for JBossLoggingConsumer (following #43809) to container-based datasource dev services, and adds a little section to the documentation about the new "showLogs" option.
Also contains a minor correction to the AppCDS documentation.
I ran
MAVEN_OPTS="-Xmx4g" ./mvnw -Dquickly
followed by./mvnw install -f extensions/devservices/
but have honestly no idea if this will work. Is there an easy way to test this locally? Should I "mvn install" the entire quarkus repo locally, make a tiny quarkus app, and update the bom version to 999-SNAPSHOT to verify this?