Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Keycloak Dev Services for standalone OIDC Client Registration extension #44270

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 2, 2024

This PR does 2 things:

@quarkus-bot quarkus-bot bot added the area/oidc label Nov 2, 2024
@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch 2 times, most recently from 59358a0 to eccccd8 Compare November 2, 2024 18:55

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch from eccccd8 to c5487f3 Compare November 2, 2024 19:09
Copy link

github-actions bot commented Nov 2, 2024

🎊 PR Preview b6d8822 has been successfully built and deployed to https://quarkus-pr-main-44270-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

This comment has been minimized.

@michalvavrik michalvavrik marked this pull request as draft November 2, 2024 20:24
@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch from c5487f3 to 19c8c62 Compare November 2, 2024 20:51
@michalvavrik michalvavrik marked this pull request as ready for review November 2, 2024 21:00

This comment has been minimized.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch from 19c8c62 to a090cea Compare November 3, 2024 14:32

This comment has been minimized.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch from a090cea to 6f21d28 Compare November 3, 2024 22:46

This comment has been minimized.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch from 6f21d28 to 9520740 Compare November 4, 2024 23:56

This comment has been minimized.

This comment has been minimized.

@michalvavrik
Copy link
Member Author

Failures seem related, must had change logic yesterday. I'll fix it.

@michalvavrik michalvavrik marked this pull request as draft November 5, 2024 09:04
@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch from 9520740 to 20ddadf Compare November 5, 2024 10:18
@michalvavrik michalvavrik marked this pull request as ready for review November 5, 2024 10:21

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch 2 times, most recently from af56b47 to 28aae1f Compare November 5, 2024 10:36

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/keycloak-dev-svc-for-admin-and-registration branch from 28aae1f to 6a34154 Compare November 5, 2024 10:51
Copy link

quarkus-bot bot commented Nov 5, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 6a34154.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Nov 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6a34154.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin self-requested a review November 5, 2024 12:41
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run this PR locally just to check non-Keycloak providers can still be shown in Dev UI and also did a run with the the OIDC client plus OIDc quickstart, thanks @michalvavrik

@sberyozkin sberyozkin merged commit 91cc2dd into quarkusio:main Nov 5, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 5, 2024
@michalvavrik michalvavrik deleted the feature/keycloak-dev-svc-for-admin-and-registration branch November 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants