-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SmallRye OpenAPI and MicroProfile OpenAPI to 4.0 #44055
Conversation
@zakkak, you should see further reduction in the native image size with this update. |
For reference, this PR is related to #43616 and #41037.
The mentioned reduction in the native image size refers to #41037 (comment) and how #43616 reverted some of that effect. |
82c43fc
to
0fc4359
Compare
I'm looking into the integration test failure. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1d2765d
to
03951ed
Compare
This comment has been minimized.
This comment has been minimized.
- OAS 3.1, normalize `type` to arrays, do not test order of health keys - Fix health schema type tests - Update Spring Web test for OAS 3.1 Signed-off-by: Michael Edgar <[email protected]>
03951ed
to
458906e
Compare
@phillip-kruger please take a look when you can, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Thanks @MikeEdgar !
Indeed, I see:
|
Hello, this PR has in description |
@michalvavrik can you point me to the repository where that should be done? |
It's this one. I myself have no rights so better talk to @gsmet about the process. |
I'll add a breaking label though. Hope that's fine. |
@MikeEdgar the migration guide is here https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.17 , I don't know if you have edit rights through. |
You can post something here and I'll add it. |
@gsmet , @michalvavrik , here is some content for the 3.17 Migration guide. MicroProfile OpenAPI 4.0MicroProfile OpenAPI and the SmallRye OpenAPI implementation have both be updated to version 4. This version brings support for OpenAPI specification version 3.1. By default, the OpenAPI documentation generated will use version The
Additionally, the default value of There are numerous other new properties for annotations and models, reflecting the changes between OpenAPI 3.0.x and 3.1.0. The release notes for the latest MicroProfile OpenAPI 4 release are available for review. |
thank you @MikeEdgar |
@gsmet just bumping this thread to make sure you got my comment with the 3.17 migration notes for OpenAPI. |
OASFactory