Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use requestVirtualHttp only if not native #33681

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

viniciusfcf
Copy link
Contributor

Native Azure functions does not need VirtualHttp to work.

I'm working in azure-functions-maven-plugin to generate native function to azure easily

@quarkus-bot
Copy link

quarkus-bot bot commented May 29, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@viniciusfcf viniciusfcf force-pushed the azure-functions-http-native-support branch from 27e35a8 to 1122336 Compare May 29, 2023 20:34
@viniciusfcf viniciusfcf changed the title requestVirtualHttp only if not native Use requestVirtualHttp only if not native May 29, 2023
@quarkus-bot

This comment has been minimized.

@gsmet gsmet requested a review from patriot1burke May 30, 2023 07:58
@patriot1burke
Copy link
Contributor

This PR needs to output different host.json and function.json files when it is native to use custom handler.

@viniciusfcf
Copy link
Contributor Author

viniciusfcf commented May 30, 2023

This PR needs to output different host.json and function.json files when it is native to use custom handler.

I'm working with Microsoft to update their plugin to generate host.json and function.json properly: microsoft/azure-maven-plugins#2302

@patriot1burke
Copy link
Contributor

FYI @viniciusfcf I've ported/quarkized azure-functions-maven-plugin in this PR that is going to be merged soon and I will be refactoring quarkus-azure-functions-http to leverage it.

#31780

@viniciusfcf viniciusfcf closed this Jun 5, 2023
@viniciusfcf viniciusfcf force-pushed the azure-functions-http-native-support branch 2 times, most recently from 1122336 to e361121 Compare June 5, 2023 20:25
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jun 5, 2023
@viniciusfcf viniciusfcf reopened this Jun 5, 2023
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Jun 5, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 5, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member

gsmet commented Jun 6, 2023

@viniciusfcf what's the status? Is it ready for a new review by @patriot1burke ?

@patriot1burke
Copy link
Contributor

IMO, right now, this does not improve the extension as you still need the correct deployment descriptor generated.

@viniciusfcf
Copy link
Contributor Author

IMO, right now, this does not improve the extension as you still need the correct deployment descriptor generated.

Let me know if I understand correctly: Do you suggest to add the capacity of this extension generate all artifacts to deploy the application in Azure Functions in build phase? (host.json, function.json...) If we do that, we do not need to update azure-maven-plugins.

But independent of who will generate the files, without approve this PR, the execution of func start does not work using native file

image

@patriot1burke
Copy link
Contributor

I do not approve this commit. Right now the extension can do everything the maven plugin can do. Deploying native only works in a specific scenario. I'd want you to figure out what the extension needs to do that.

@viniciusfcf
Copy link
Contributor Author

I do not approve this commit. Right now the extension can do everything the maven plugin can do. Deploying native only works in a specific scenario. I'd want you to figure out what the extension needs to do that.

I understand and completely agree with you @patriot1burke, do you know when the extension should be ready? Microsoft team and the Santander are very interesting in that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants