-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use requestVirtualHttp only if not native #33681
base: main
Are you sure you want to change the base?
Use requestVirtualHttp only if not native #33681
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
27e35a8
to
1122336
Compare
This comment has been minimized.
This comment has been minimized.
This PR needs to output different host.json and function.json files when it is native to use custom handler. |
I'm working with Microsoft to update their plugin to generate host.json and function.json properly: microsoft/azure-maven-plugins#2302 |
FYI @viniciusfcf I've ported/quarkized azure-functions-maven-plugin in this PR that is going to be merged soon and I will be refactoring quarkus-azure-functions-http to leverage it. |
1122336
to
e361121
Compare
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@viniciusfcf what's the status? Is it ready for a new review by @patriot1burke ? |
IMO, right now, this does not improve the extension as you still need the correct deployment descriptor generated. |
I do not approve this commit. Right now the extension can do everything the maven plugin can do. Deploying native only works in a specific scenario. I'd want you to figure out what the extension needs to do that. |
I understand and completely agree with you @patriot1burke, do you know when the extension should be ready? Microsoft team and the Santander are very interesting in that |
Native Azure functions does not need VirtualHttp to work.
I'm working in azure-functions-maven-plugin to generate native function to azure easily