Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#154 & #155 #278

Merged
merged 1 commit into from
Sep 20, 2023
Merged

#154 & #155 #278

merged 1 commit into from
Sep 20, 2023

Conversation

turing85
Copy link
Contributor

@turing85 turing85 commented Sep 17, 2023

  • integrate camel-support, but
  • don't include camel-context-…enhancements

Resolves #154
Resolves #155

@turing85 turing85 added the enhancement New feature or request label Sep 17, 2023
@github-actions

This comment has been minimized.

@turing85 turing85 removed the request for review from gsmet September 17, 2023 18:15
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@middagj middagj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the conclusion, we maintain our own Camel tests?

@turing85
Copy link
Contributor Author

turing85 commented Sep 19, 2023

What is the conclusion, we maintain our own Camel tests?

Moving the tests is not in scope of #154 and #155. We have #158 to move the tests.

@github-actions

This comment has been minimized.

@turing85
Copy link
Contributor Author

turing85 commented Sep 20, 2023

The PR can should not be merged yet. We should wait until quarkus 3.4.0 is (officially) released so that we can use the quarkus-camel-bom of 3.4.0 (right now, this bom still points to camel 4.0.0-RC2).

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

🚦Reports for run #677🚦

Reports will be posted here as they get available.

🥳 JUnit JVM Test passed

Passed Failed Skipped
✅ 142 ❌ 0 ⚠️ 0

You can see the report here.

🥳 JUnit Native Test passed

Passed Failed Skipped
✅ 91 ❌ 0 ⚠️ 0

You can see the report here.

@turing85 turing85 merged commit 61058a9 into main Sep 20, 2023
@turing85 turing85 deleted the #154+#155 branch September 20, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code to register @Identifier beans in camel context Integrate camel enhancements in quarkus-artemis 3
3 participants