Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple files, including shell regular expressions #3

Closed
wants to merge 1 commit into from

Conversation

khamer
Copy link

@khamer khamer commented Oct 28, 2018

This is a quick implementation for #2 - I've made it support variadic file/directory names. The summary isn't perfect, but I think we'd need to rework the async/await stuff with cipher() for that, and to be honest, I'm not sure why you're using async/await there.

This will work with shell regular expressions; so you can run commands like

$ warshield encrypt *.secret

$ warshield decrypt {foo,bar}files

$ warshield encrypt $HOME/secret-project-*

@quantumsheep
Copy link
Owner

Hey 👋 First of all, thanks for showing interest to WarShield and for contributing!

You got a good idea for multiple files, I take it for a real functionality.

However there is an issue, cipher() is a only-one use function because it outputs different things that are supposed to be write only one time (like Crawling directories... Done!).
To fix this issue, we will need to work with the cipher() function and not to loop over all requested files in gate().

gate() is only for password asking, only cipher() should do real operations.
I need to rework the architecture tho 😄

Fix those things and I will be very happy to merge your contributions!

@quantumsheep
Copy link
Owner

Closed because of architecture reworking - this PR will be reworked tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants