Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation to Python 3.10 environment #209

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

pavoljuhas
Copy link
Contributor

@pavoljuhas pavoljuhas commented Oct 3, 2024

This is needed for internal documentation tool.
All unit tests pass with Python 3.10.

Also restrict the CI check to use pylint-2 as
a temporary workaround for #210.

@dstrain115 dstrain115 self-requested a review October 3, 2024 23:06
@dstrain115
Copy link
Collaborator

I suppose this is fine if this is blocking other doc updates, but if it is just unitary, I'd rather fix the root cause. We pulled the copyright checker from cirq, and I think we would like to continue doing the same thing as cirq is doing.

@pavoljuhas
Copy link
Contributor Author

The pylint version downgrade here is just to let the CI pass for this PR.
The actual change here is to allow installation for 3.10 which is one
of the versions supported by the documentation tool (not sure if it can do 3.12).

@dstrain115
Copy link
Collaborator

I see, okay. Let's then do this for now.

@dstrain115 dstrain115 merged commit 00dbc77 into quantumlib:main Oct 4, 2024
6 checks passed
@pavoljuhas pavoljuhas deleted the allow-python-3.10 branch October 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants