Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sparse simulator by default #187

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

losos0
Copy link
Collaborator

@losos0 losos0 commented Mar 21, 2024

No description provided.

losos0 added 2 commits March 20, 2024 18:42
QuantumWorld now defaults to using SparseSimulator instead of
cirq.Simulator for the sampler. This should be a good default because
users are likely to construct sparse states with the sort of operations
provided by Unitary, and with the previous default performance problems
quickly arise as soon as you have more than a handful of qubits.
compile_to_qubits, which is required for
the sparse simulator, is now automatically enabled when using a sparse
simulator.

All examples should now be using sparse simulation except Tic-Tac-Toe.
I left the Tic-Tac-Toe example using the old default of cirq.Simulator
since I'm not sure if the states are actually sparse in this game, and
it would have been some effort to fix tests.
@losos0 losos0 requested review from dstrain115 and cognigami March 21, 2024 01:06
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Glad to see this happen.

@losos0 losos0 merged commit 35f7b97 into quantumlib:main Mar 22, 2024
6 checks passed
@losos0 losos0 deleted the sparse-default branch March 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants