[Quantum Chess] Improve test failure output #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losos0
force-pushed
the
testoutput
branch
2 times, most recently
from
9f1386d to
0dc8143
Compare
dstrain115
reviewed
Mar 19, 2024
unitary/alpha/quantum_world.py
Outdated
| ] = new_world.get_object_by_name(value_obj.name) | ||
| new_dict[new_world.get_object_by_name(key_obj.name)] = ( | ||
| new_world.get_object_by_name(value_obj.name) | ||
| ) |
There was a problem hiding this comment.
What's up with all these formatting changes? Are you on the same version of black as everyone else?
There was a problem hiding this comment.
There is a CI check on this repo that fails if the formatting is not identical to that which whichever black version the workflow installs produces, so I had to add a formatting commit to make it pass.
In the meantime, Peter already hit the same issue and merged a commit making those formatting changes, so now I can remove mine.
There was a problem hiding this comment.
ok, perfect. I will merge this then.
=== Before ===
> assert all_in, print_samples(samples)
E AssertionError: None
E assert False
test_utils.py:37: AssertionError
------------------------------------------------- Captured stdout call -------------------------------------------------
Using seed 2353196025
[211106778865792]
{211106778865792, 211106242027648, 70369290510464, 211106778898560}
['h1', 'f2', 'g2', 'e3', 'h3', 'f4', 'g6', 'h6']: 476
['h1', 'f2', 'g2', 'h2', 'e3', 'h3', 'f4', 'g6', 'h6']: 17
['h1', 'f2', 'g2', 'h2', 'e3', 'h3', 'g6', 'h6']: 5
['h1', 'f2', 'g2', 'e3', 'h3', 'f4', 'g6']: 2
=== After ===
> assert all_in, message("Unexpected bitboard in samples")
E AssertionError: Unexpected bitboard in samples
E assert False
test_utils.py:47: AssertionError
------------------------------------------------- Captured stdout call -------------------------------------------------
Using seed 3713866156
Expected bitboards:
[f2 g2 h2 g3 d6 f7 g7 h7 b8 d8 h8]
Sample distribution:
493 [f2 g2 h2 g3 d6 f7 g7 h7 b8 d8 h8]
7 [f2 g2 h2 g3 d6 f7 g7 h7 b8 h8]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 2nd commit message for an example.