[Quantum Chinese Chess] Improve chess board printing #176
Conversation
madcpf
commented
Jan 31, 2024
•
madcpf
commented
- Print the board with sampled probabilities.
- For proper print, different treatment is made for English vs Chinese and Sublime terminus vs mac/gLinux terminal.
|
Not sure why some other files fail Lint check. |
| @@ -28,6 +28,20 @@ | |||
| # The default initial state of the game. | |||
| _INITIAL_FEN = "RHEAKAEHR/9/1C5C1/P1P1P1P1P/9/9/p1p1p1p1p/1c5c1/9/rheakaehr w---1" | |||
|
|
|||
| # Constants for printing board | |||
| _RESET = "\033[0m" | |||
There was a problem hiding this comment.
Does all this work in colab? I'm not sure how portable all these unix terminal codes are. If it works in colab though, that's probably good enough
There was a problem hiding this comment.
Hi Doug, yes I just checked that it works in cola, with https://colab.research.google.com/drive/1B-7LmTN_gL4T1akVqUtoYO5dwzK_3IVK?usp=sharing, but replaced the files with this PR.
| print_probabilities=True, | ||
| peek_result: List[int] = None, | ||
| sublime_terminus: bool = True, | ||
| ): |
There was a problem hiding this comment.
Please add docstring for the arguments. It particular, I am not sure what sublime_terminus is? Is it a specific terminal app?
There was a problem hiding this comment.
Thanks Doug. It's added. Sublime Text is a handy editor, while Sublime Terminus is its integrated terminal.
| probabilities: List[float] = None, | ||
| print_probabilities=True, | ||
| peek_result: List[int] = None, | ||
| sublime_terminus: bool = True, |
There was a problem hiding this comment.
I'd consider making this an enum rather than a bool, and add a plain option, such as:
class TerminalType(enum.Enum):
PLAIN_ASCII = 0
MAC_AND_LINUX = 1
SUBLIME_TERMINUS = 2
There was a problem hiding this comment.
Thanks Doug. I just added MAC_OR_LINUX and SUBLIME_TERMINUS_OR_COLAB (since it turns out that colab handles full width chars in a similar way as sublime terminus). What do you mean about plain ascii?
