feat(qvol): First version of adding Quantum Volume to Recirq. #27
Conversation
This just adds a simple task and driver Script for now. More to come, such as precomputing the generated circuits and the optimal qubits to run on in other tasks.
There was a problem hiding this comment.
Making the module recirq/benchmarks might be more future proof, what do you think?
I encourage you to add a notebook to docs/benchmarks/Quantum-Volume.ipynb that describes this benchmark and executes the tasks with a simulator. This can be simple for now and can open an issue to flesh out the documentation
| tabulation_resolution=0.008), | ||
| add_readout_error_correction=task.readout_error_correction) | ||
| # Save the results CODE REVIEW QUESTION: This attempts to serialize a QuantumVolumeResult, which contains a | ||
| # Circuit, which contains a SerializableDevice, which is not JSON serializable. What's the best way to resolve |
There was a problem hiding this comment.
does the circuit's device have any bearing on the experiment? or is it just hanging around? [I've always found the fact that a Circuit has a Device to be somewhat vestigial]
If it's just hanging around, you could set it to None with a note. Ideally SerializableDevice would be JSON serializable lol
There was a problem hiding this comment.
It's just hanging around - setting it to None allows me to serialize it, but then I can't deserialize it because it expects a circuit. I'm thinking I should just try to add serialization to SerializableDevice - WDYT?
|
Sorry for the delay, PTAL. Thanks! |
|
closing as stale |
This just adds a simple task and driver Script for now. More to come, such as precomputing the generated circuits and the optimal qubits to run on in other tasks.
#24