XEB fidelity estimator for large circuits #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strilanc
requested changes
Sep 17, 2019
kevinsung
reviewed
Sep 18, 2019
kevinsung
reviewed
Sep 18, 2019
Strilanc
requested changes
Sep 23, 2019
| from cirq.sim import final_wavefunction | ||
|
|
||
|
|
||
| def compute_linear_xeb_fidelity( |
There was a problem hiding this comment.
The word compute is redundant; drop it. Just linear_xeb_fidelity.
There was a problem hiding this comment.
Or e.g. linear_xeb_fidelity_of_samples
There was a problem hiding this comment.
Agree with dropping "compute". I wouldn't append "of_samples" since it's equally redundant: samples are the only type of input that XEB fidelity estimator supports (as is explained in the comments).
| n_incoherent = int(depolarization * n_samples) | ||
| n_coherent = n_samples - n_incoherent | ||
| incoherent_samples = np.random.randint(dim, size=n_incoherent) | ||
| circuit_with_measurements = cirq.Circuit.from_ops( |
There was a problem hiding this comment.
Append with circuit + cirq.measure(...)
| incoherent_samples = np.random.randint(dim, size=n_incoherent) | ||
| circuit_with_measurements = cirq.Circuit.from_ops( | ||
| circuit, cirq.measure(*qubit_order, key=MEASUREMENT_KEY)) | ||
| if n_coherent > 0: |
There was a problem hiding this comment.
I think this optimize belongs inside sim.run instead of outside of it. Also this is test code; don't worry about it.
kevinsung
reviewed
Sep 23, 2019
Strilanc
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #2113.