Detect duplicate measurement keys #1687 #1862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvamsikrishnad
requested review from
Strilanc and
dabacon
and removed request for
Strilanc
iamvamsikrishnad
requested review from
Ashalynd
and removed request for
Ashalynd
iamvamsikrishnad
added
the
Ready for Re-Review
|
@iamvamsikrishnad Please fix the merge conflicts. |
Strilanc
requested changes
Sep 25, 2019
| raise ValueError('Measurement key {} repeated'.format(key)) | ||
| seen.add(key) | ||
| return (self._measurement_duration, self._exp_w_duration, | ||
| self._exp_z_duration, self.qubits) |
There was a problem hiding this comment.
I'm surprised the formatter lets lack of trailing newlines through
| @@ -227,31 +227,6 @@ def test_validate_scheduled_operation_not_adjacent_exp_11_exp_w(): | |||
| d.validate_schedule(s) | |||
|
|
|||
|
|
|||
| def test_validate_circuit_repeat_measurement_keys(): | |||
There was a problem hiding this comment.
Why was this test removed with no test being added to e.g. circuit_test.py to compensate? What is checking that we detect dupes?
|
Hey @iamvamsikrishnad. I want to get this in. Please address the requested changes. |
|
@vtomole : I will take a look at this after 2 weeks, as I busy with something else now. Please let me know if you need it in a shorter time. |
|
@iamvamsikrishnad No problem. Take your time. |
|
I am closing this one and submitting a new PR, as this is quite old and some of the changes I feel are irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2152.